feat(serve): support request carries .(DOT) character #2634

anncwb · 2021-03-22T02:32:05Z

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Read the Pull Request Guidelines and follow the Commit Convention.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

What is the purpose of this pull request?

Bug fix
New Feature
Documentation update
Other

Description

This issue is actually the same as bripkens/connect-history-api-fallback#25. connect-history-api-fallback is configured by disabledotrule to solve this problem.

I'm not sure if it is necessary to add an option to solve this problem, or it should be told not to use the request path with .(Dot) character

Additional context

…2628

patak-dev · 2021-03-22T13:32:49Z

As per this comment by the author of the middleware
bripkens/connect-history-api-fallback#25 (comment)

Shouldn't filesystem be accessed first and then fallback would go to history api?

In a perfect world, yes. Unfortunately, there are very many ways where this gets complicated:

What is the root directory for filesystem access?
Is filesystem access permitted for this user?
Is the file served in some kind of special way, e.g. by transformation from a template?
…
On top of all this, the dot rule has been part of this middleware since day 1 (worked perfect for my use case at that time) and I don't want to change the middleware's default settings (and by that upset other users for which this also works fine).

Since Vite user base is still small, maybe we need to re-evaluate this default. @anncwb, do you see a problem with disabling the dot rule by default?

Are these issues related #2245, #2190?

About the option, maybe it should be under middlewares.history so users can configure the middleware and no only this rule?

anncwb · 2021-03-23T01:21:43Z

@matias-capeletto Sorry, I didn't see the question #2245. Then we no longer need to provide this configuration, it should be implemented by the user writing middleware

patak-dev · 2021-04-24T10:49:48Z

@anncwb if I understand your last message, you think we should close this PR?
I still think that it is a good idea to expose this option, but if we have a clear workaround, we could wait to avoid exposing options internal options.

fubhy · 2021-09-01T11:32:08Z

We are running into this exact issue when serving preview builds via vite preview because the dev server plugin recommended in one of the related issues (vite-plugin-rewrite-all) only kicks in in development mode.

Our use case requires support for URLs with dots because we have path segments with JWT tokens for sign-up purposes to verify the email address of the user.

benatshippabo · 2021-09-28T00:56:08Z

@anncwb are you still working on this?

levydev · 2022-07-13T14:00:29Z

New to vite and am experiencing this problem.
I don't recall installing vite in my vue3 project but it seems to be in play when I run "npm run dev"
Do I nee to upgrade or is this still an issue?

bluwy · 2022-07-13T16:12:39Z

This is still an issue and we've put it in the team board for discussion in the next team meeting (if we can get to it as they're already a lot of things on the board).

levydev · 2022-07-13T17:19:07Z

Thanks. Kind of a blocker for anyone using dots in their urls Is there a workaround for "npm run dev" to develop and test in localhost?

…

On Wed, Jul 13, 2022 at 12:12 PM Bjorn Lu ***@***.***> wrote: This is still an issue and we've put it in the team board for discussion in the next team meeting (if we can get to it as they're already a lot of things on the board). — Reply to this email directly, view it on GitHub <#2634 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6M465BB7XW3FJXTZ3UYYLVT3TIJANCNFSM4ZSHQLZQ> . You are receiving this because you commented.Message ID: ***@***.***>

bluwy · 2022-07-13T18:48:20Z

One of the comment above suggested vite-plugin-rewrite-all, but I personally use a custom patch.

hi-reeve · 2022-07-15T13:08:37Z

will this not be merged?

mskr · 2022-08-11T10:32:18Z

Our company also uses https://www.npmjs.com/package/vite-plugin-rewrite-all now

kalda341 · 2022-10-04T22:01:49Z

Plugin works for us too, but it would be nice not to require it.

GOI17 · 2022-12-06T02:55:39Z

any updates on this?

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template

@click

* integrated #355 Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template * made shure that the feedback and the calendar APIs route to our servers * fixed the General message modal throwiing an error if no information_modal is supplied * fixed typing bugs * rebased #4149cc0f680c48f689172cea6b0c861f970990d4 * fixed deployment issues * [SSR-1] Removal of Rendertron (#474) Remvoal of Rendertron * typing fixes * linting fixes * fixed links not being able to be copied * linting fixes * fixed html content in translations not being displayed properly * linting fixes * fixed one translation * translation fixes * renamed methods in the browser detection * added the canonical link to the html to make shure chrome is not confused about our stagings * Migrate new POI URL * Fix a bug where the map would not update when updating the DetailsView * migrated ##502 * migrated #532 * Change arguments for scrolling (still sometimes not working properly yet) * migrated the addition of the TUM logo * updated the api_types and ran the linter * fixed default thumbnails not being displayed and not being localised * fixed the api view not being correctly linked to * added the openapi definition to the cdn to correctly load the api page * made the app reload on theme/language change fixing this not applying * fixed the window continuously reloading * fixed the about view not being reflective of the actual url being used currently * fixed the details view being stuck loading for an unnessesaryly long time * fixed small design issues in the feedback modal * added debug information to the language toggler * added VITE_APP_URL to the environent variables * tested a diffferent approach to introduce VITE_APP_URL into the webclient * maybe fixed the cookies not loading properly? * renamed utils to composables * added a saveCooke() function to centralise this functionality * aded an debug alert * removed alert * tested a different way to scope cookies * removed logging statements from the code * uptated the typescript bindings for the openapi spec * bumped our linting suite and `swagger-ui` * bumped maplibre to v3 as in master * Add resizeObserver to scroll to y-positions > 0 on forward/backward navigation. The problem is that the scroll is intiated before the components are updated. If the previous page was shorter than the next one, the browser might not scroll then. I am not sure exactly why this breaks now and didn't break in the vue2 version, but I think it is because Vue router is now async. The solution with a resizeObserver requires the least changes. Else we would need to add scrolling code to all views. * added translations to the search and general feedback button `aria-label`'s --------- Co-authored-by: octycs <git@octycs.eu>

feat(serve): support request carries .(DOT) character fix #2415, fix #…

827b10b

…2628

anncwb requested a review from patak-dev March 22, 2021 02:32

anncwb added the 🔍 review needed label Mar 22, 2021

anncwb requested a review from yyx990803 March 22, 2021 02:40

anncwb added the enhancement New feature or request label Mar 22, 2021

Shinigami92 previously approved these changes Mar 22, 2021

View reviewed changes

Shinigami92 removed the 🔍 review needed label Aug 4, 2021

Shinigami92 added the needs rebase label Sep 1, 2021

patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label May 12, 2022

sapphi-red mentioned this pull request Jun 14, 2022

Fix:vitejs#5265 Add disableDotRule option to allow path contains dot #6170

Closed

9 tasks

silverwind mentioned this pull request Dec 12, 2022

Dots in URL lead to 404 (regression?) #2415

Closed

3 tasks

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Jan 22, 2023

added the vite-plugin-rewrite-all dependency, as a workaround for vit…

2fc873c

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Mar 11, 2023

added the vite-plugin-rewrite-all dependency, as a workaround for vit…

011304f

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Mar 11, 2023

added the vite-plugin-rewrite-all dependency, as a workaround for vit…

129e0fd

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Mar 11, 2023

added the vite-plugin-rewrite-all dependency, as a workaround for vit…

55527ea

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

CommanderStorm added a commit to TUM-Dev/NavigaTUM that referenced this pull request Mar 11, 2023

added the vite-plugin-rewrite-all dependency, as a workaround for vit…

730430d

…ejs/vite#2415 This will be solved if vitejs/vite#2634 is merged

patak-dev dismissed Shinigami92’s stale review via 827b10b June 6, 2023 19:29

slumericanBx mentioned this pull request Jul 3, 2023

[Snyk] Upgrade esbuild from 0.17.19 to 0.18.0 slumericanBx/vite#1

Open

sapphi-red mentioned this pull request Aug 17, 2023

feat!: allow path containing . to fallback to index.html #14142

Merged

9 tasks

patak-dev closed this in #14142 Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(serve): support request carries .(DOT) character #2634

feat(serve): support request carries .(DOT) character #2634

anncwb commented Mar 22, 2021 •

edited

Loading

patak-dev commented Mar 22, 2021

anncwb commented Mar 23, 2021

patak-dev commented Apr 24, 2021

fubhy commented Sep 1, 2021

benatshippabo commented Sep 28, 2021

levydev commented Jul 13, 2022

bluwy commented Jul 13, 2022

levydev commented Jul 13, 2022 via email

bluwy commented Jul 13, 2022

hi-reeve commented Jul 15, 2022

mskr commented Aug 11, 2022

kalda341 commented Oct 4, 2022

GOI17 commented Dec 6, 2022

feat(serve): support request carries .(DOT) character #2634

feat(serve): support request carries .(DOT) character #2634

Conversation

anncwb commented Mar 22, 2021 • edited Loading

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

Additional context

patak-dev commented Mar 22, 2021

anncwb commented Mar 23, 2021

patak-dev commented Apr 24, 2021

fubhy commented Sep 1, 2021

benatshippabo commented Sep 28, 2021

levydev commented Jul 13, 2022

bluwy commented Jul 13, 2022

levydev commented Jul 13, 2022 via email

bluwy commented Jul 13, 2022

hi-reeve commented Jul 15, 2022

mskr commented Aug 11, 2022

kalda341 commented Oct 4, 2022

GOI17 commented Dec 6, 2022

anncwb commented Mar 22, 2021 •

edited

Loading