Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve issue templates #2645

Merged
merged 16 commits into from
Mar 23, 2021
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 37 additions & 19 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -1,39 +1,57 @@
---
name: Bug report
about: Create a report to help us improve
name: "\U0001F41E Bug report"
about: Report an issue with Vite
title: ''
labels: 'bug: pending triage'
assignees: ''
---

<!--
中文用户请注意:请仔细阅读以下模版,如果不遵循模版,issue 将会被直接关闭。
-->

**⚠️ IMPORTANT ⚠️ Please do not ignore this template. If you do, your issue will be closed immediately.**
<!-- 中文用户请注意:请仔细阅读以下模版,如果不遵循模版,issue 将会被直接关闭。 -->
<!-- IMPORTANT: Please do not ignore this template. If you do, your issue will be closed immediately. -->
Copy link
Member

@GrygrFlzr GrygrFlzr Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ⚠️ emoji really draws attention to the warning, versus the newly commented out version. Maybe add that back in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the same with #2645 (comment), the text is only visible in the draft view of the issue and shown in the comment, therefore it is not rendered as an icon/emoji but an unicode symbol.

Is there maybe another way of drawing attention?

Maybe we could try <!-- !!! IMPORTANT !!! Please do not ignore this template. If you do, your issue will be closed immediately. -->


- [ ] Read [the docs](https://vitejs.dev/guide/).
- [ ] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
- [ ] This is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).
### Describe the bug

## Describe the bug
<!-- A clear and concise description of what the bug is. -->

A clear and concise description of what the bug is.
<!-- If you intend to submit a PR for this issue, tell us in the description. Thanks! -->

## Reproduction
### Reproduction

Please provide a link to a repo that can reproduce the problem you ran into.
<!--
Please provide a link to a repo that can reproduce the problem you ran into.

A reproduction is **required** unless you are absolutely sure that the the problem is obvious and the information you provided is enough for us to understand what the problem is. If a report has only vague description (e.g. just a generic error message) and has no reproduction, it will receive "need reproduction" label. If no reproduction is provided after 3 days, it will be auto-closed.
A reproduction is required unless you are absolutely sure that the issue is obvious and the provided information is enough to understand the problem. If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "need reproduction" label. If no reproduction is provided after 3 days, it will be auto-closed.
-->

## System Info
### System Info

- `vite` version:
- Operating System:
- Node version:
- Package manager (npm/yarn/pnpm) and version:
Copy link
Member

@GrygrFlzr GrygrFlzr Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding:

  • The output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers

Which produces output like this:

  System:
    OS: Windows 10 10.0.19042
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 14.19 GB / 31.95 GB
  Binaries:
    Node: 14.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.6.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 89.0.4389.90
    Edge: Spartan (44.19041.423.0), Chromium (89.0.774.54)
    Internet Explorer: 11.0.19041.1
  npmPackages:
    vite: ^2.1.2 => 2.1.2

Are there any other packages we want to check the version of?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, we could add that as a recommendation but I think nobody will do it if it is not required. I would really like this is required, but maybe it is too much. Let's add it with a strong word to try to push people that way at least


## Logs (Optional if provided reproduction)
### Logs <!-- (Optional if provided reproduction) -->

<!--
Please try not to insert an image but copy paste the log text.

1. Run `vite` or `vite build` with the `--debug` flag.
2. Provide the error log here.
`node` is used as highlight to improve some colors in stack-traces.
If it doesn't work quite well, try `console`.
-->

```node

1. Run `vite` or `vite build` with the `--debug` flag.
2. Provide the error log here.
```

---

### Before submitting the issue, please make sure you do the following

- [ ] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md).
- [ ] Read the [docs](https://vitejs.dev/guide).
- [ ] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- [ ] Provide a description in this issue that describes the bug.
- [ ] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
- [ ] This is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).
Shinigami92 marked this conversation as resolved.
Show resolved Hide resolved
29 changes: 17 additions & 12 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
---
name: Feature request
about: Suggest an idea for this project
name: "\U0001F680 New feature proposal"
about: Propose a new feature to be added to Vite
title: ''
labels: ''
labels: 'feat: pending triage'
assignees: ''

---

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
### Clear and concise description of the problem

<!-- As a developer using Vite I want [goal / wish] so that [benefit]. -->

<!-- If you intend to submit a PR for this issue, tell us in the description. Thanks! -->

### Suggested solution

<!-- In module [xy] we could provide following implementation... -->

### Alternative

**Describe the solution you'd like**
A clear and concise description of what you want to happen.
<!-- Clear and concise description of any alternative solutions or features you've considered. -->

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
### Additional context

**Additional context**
Add any other context or screenshots about the feature request here.
<!-- Any other context or screenshots about the feature request here. -->
28 changes: 14 additions & 14 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<!-- Thank you for contributing! -->

### Before submitting the PR, please make sure you do the following
### Description

- [ ] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md).
- [ ] Read the [Pull Request Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md#pull-request-guidelines) and follow the [Commit Convention](https://github.com/vitejs/vite/blob/main/.github/commit-convention.md).
- [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
- [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`).
- [ ] Ideally, include relevant tests that fail without this PR but pass with it.
<!-- Please insert your description here and provide especially info about the "what" this PR is solving -->

### Additional context

<!-- e.g. is there anything you'd like reviewers to focus on? -->

---

### What is the purpose of this pull request? <!-- (put an "X" next to an item) -->

Expand All @@ -15,12 +17,10 @@
- [ ] Documentation update
- [ ] Other

---

### Description

<!-- Please insert your description here and provide especially info about the "what" this PR is solving -->

### Additional context
### Before submitting the PR, please make sure you do the following

<!-- e.g. is there anything you'd like reviewers to focus on? -->
- [ ] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md).
- [ ] Read the [Pull Request Guidelines](https://github.com/vitejs/vite/blob/main/.github/contributing.md#pull-request-guidelines) and follow the [Commit Convention](https://github.com/vitejs/vite/blob/main/.github/commit-convention.md).
- [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
- [ ] Provide a description in this PR that addresses **what** the PR is solving, or reference the issue that it solves (e.g. `fixes #123`).
- [ ] Ideally, include relevant tests that fail without this PR but pass with it.