Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add repository.directory to packages/**/package.json #2687

Merged
merged 1 commit into from
Mar 29, 2021
Merged

feat: Add repository.directory to packages/**/package.json #2687

merged 1 commit into from
Mar 29, 2021

Conversation

cawa-93
Copy link
Contributor

@cawa-93 cawa-93 commented Mar 25, 2021

Description

According to the recommendations of the npm:

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:

{
  "repository": {
    "type": "git",
    "url": "https://github.com/facebook/react.git",
    "directory": "packages/react-dom"
  }
}

This should help various tools like dependabot or renovate to get more information about the package: package url, changelog etc.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added p1-chore Doesn't change code behavior (priority) 🔍 review needed labels Mar 25, 2021
@patak-dev patak-dev merged commit 0ecff94 into vitejs:main Mar 29, 2021
@cawa-93 cawa-93 deleted the repository.directory branch March 29, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants