Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): css.preprocessorOptions.stylus doesn't support additionalData #2869

Closed
wants to merge 4 commits into from

Conversation

hiblacker
Copy link

@hiblacker hiblacker commented Apr 6, 2021

Description

css.preprocessorOptions.stylus doesn't support additionalData, which is different form less and sass.

Additional context

It took me a long time to read vite and stylus source code. And then I found the following solution, which is unfriendly. The additionalData should support all preprocessor. Excuse me for any omission or negligence if there is. I'll correct timely.

export default {
    css: {
        preprocessorOptions: {
            stylus: {
                use: [ 
                   style => {
                        style.import(path.join(__dirname, "src/css/var.styl"))
                    },
                ],
            },
        },
    },
}

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added bug feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Apr 6, 2021
@patak-dev
Copy link
Member

@hiblacker looks like there conflicts against main, could you take a look?

@antfu
Copy link
Member

antfu commented Apr 17, 2021

Looks like #2860 is already covered this.

@antfu antfu closed this Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants