Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/worker): Support shared inline worker #3948

Closed
wants to merge 1 commit into from

Conversation

NotWoods
Copy link
Contributor

Description

This PR simplifies some of the worker plugin logic by moving duplicate code into a shared function. The new function checks if a URL includes either ?worker or ?sharedworker, then returns a function to build the relevant new Worker(...) function call string.

This also fixes an issue with the plugin where ?sharedworker is ignored for blob URLs.

Additional context

I'm also going to build off this for my rebase in #2494


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

@NotWoods would you resolve the conflicts?

@sapphi-red
Copy link
Member

sapphi-red commented Jun 14, 2022

Closing as this seems to be fixed by #7914. Thanks for the PR.

@sapphi-red sapphi-red closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants