Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shims-vue.d.ts #3990

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Update shims-vue.d.ts #3990

merged 1 commit into from
Jul 10, 2021

Conversation

falstack
Copy link
Contributor

@falstack falstack commented Jun 28, 2021

add eslint-disable for DefineComponent,see:#3759 and vuejs/vue-cli#6023

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Jun 29, 2021

/cc @Shinigami92 do you have any better idea of this?

@Shinigami92
Copy link
Member

/cc @Shinigami92 do you have any better idea of this?

I could be wrong, but I think that this file can maybe fully removed 🤔
Last time I checked that and removed it, I didn't had any type issues 🤔

@antfu
Copy link
Member

antfu commented Jul 6, 2021

If we use Volar (note it's VS Code only atm), yes, it will be handled by the extension. But I guess the template is not bound to the editor extension.

@Shinigami92
Copy link
Member

If we use Volar (note it's VS Code only atm), yes, it will be handled by the extension. But I guess the template is not bound to the editor extension.

Ah okay, yes I'm using Volar. So I need to test it without Volar activated? Will do this later.

@patak-dev patak-dev merged commit 9c455b2 into vitejs:main Jul 10, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants