fix(plugin-vue): don't use object spread in the config hook #5155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The config object will be merged recursively in vite core, so object
spread shouldn't be used:
vite/packages/vite/src/node/config.ts
Line 308 in 5cf4e69
Otherwise, it would cause an array field to be concatenated with itself.
Fixes #5150
Additional context
I didn't add a test for that issue, because it's not a use case that we intended to support. The documentation clearly stated that the
define
field is of typeRecord<string, string>
.But it's a good programming practice to remove the unnecessary object spread anyway.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).