Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): support headers configurable #5580

Merged
merged 4 commits into from
Dec 30, 2021
Merged

feat(server): support headers configurable #5580

merged 4 commits into from
Dec 30, 2021

Conversation

stygian-desolator
Copy link
Contributor

Description

support server headers configurable.

close #3857
close #4736

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 marked this pull request as draft November 8, 2021 07:54
@stygian-desolator stygian-desolator force-pushed the feat/support-headers-configurable branch 2 times, most recently from 5deb460 to a7210a0 Compare November 8, 2021 23:43
@stygian-desolator stygian-desolator marked this pull request as ready for review November 9, 2021 00:00
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 9, 2021
Shinigami92
Shinigami92 previously approved these changes Nov 9, 2021
View reviewed changes
@stygian-desolator stygian-desolator force-pushed the feat/support-headers-configurable branch from a7210a0 to e5e8cd2 Compare November 26, 2021 00:51
@Shinigami92 Shinigami92 added the YAO Yet another option... label Nov 26, 2021
@Shinigami92 Shinigami92 mentioned this pull request Nov 26, 2021
Closed
6 tasks
Shinigami92
Shinigami92 previously approved these changes Dec 17, 2021
View reviewed changes
@patak-dev patak-dev added this to the 2.8 milestone Dec 19, 2021
@patak-dev
Copy link
Member

@truongsinh @apazzolini we are planning to merge this PR in the next weeks targeting Vite 2.8. If you have some time, it would be helpful if you could check that this feat covers your requested use case (and if possible testing it against your projects). Thanks!

@patak-dev patak-dev merged commit db36e81 into vitejs:main Dec 30, 2021
@sanyuan0704
Copy link
Contributor

Thanks!

@bluwy bluwy mentioned this pull request Mar 12, 2022
Closed
@sapphi-red sapphi-red mentioned this pull request Jun 7, 2022
Merged
4 tasks
@ngbrown ngbrown mentioned this pull request Apr 26, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

@ygj6 ygj6 Awaiting requested review from ygj6

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) YAO Yet another option...
Projects
None yet
Milestone
2.8
5 participants
@stygian-desolator @patak-dev @sanyuan0704 @Shinigami92 @ygj6