Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): setup jsx script no hmr #6568

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jan 20, 2022

Description

fix: #6528

Additional context

Forgot to judge whether the setup script has changed in the hmr processing vue
this PR add this judge.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho changed the title fix(vue): setup jsx script no hmr fix(plugin-vue): setup jsx script no hmr Jan 20, 2022
@patak-dev patak-dev merged commit c84601c into vitejs:main Feb 23, 2022
@oliverzy
Copy link
Contributor

Thanks, this PR fixes a serious bug that affect the UI library like naive-ui which relies on render function heavily.

@poyoho poyoho deleted the fix(vue)/setup-jsx-script branch February 24, 2022 08:34
sxzz added a commit to unplugin/unplugin-vue that referenced this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hmr doesn't work when using jsx in .vue file
5 participants