Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-legacy): don't include SystemJS in modern polyfills #6902

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

Menci
Copy link
Contributor

@Menci Menci commented Feb 13, 2022

Description

Currently the legacy plugin bundles SystemJS in both legacy and modern (if any) polyfills if we set options.externalSystemJS to false. But on the modern target it doesn't use SystemJS.

I just pass false when building modern polyfills. The parameter externalSystemJS is renamed to excludeSystemJS to avoid ambiguity.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 14, 2022
@patak-dev patak-dev merged commit eb47b1e into vitejs:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants