fix(hmr): catch thrown errors when connecting to hmr websocket #7111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #7110 by catching thrown errors in a try block and logging the error.
Note that this just prevents errors from stopping execution, rather than enabling hot reloading to continue to work, even in a degraded capacity.
To have hot reloading continue to work in these contexts,
__HMR_HOSTNAME__
must be set and the WebSocket must allow cross-origin connections.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).