Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SASS modern api #7170

Closed
wants to merge 2 commits into from
Closed

feat: support SASS modern api #7170

wants to merge 2 commits into from

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Mar 4, 2022

Description

Relate: #7116, #6734
FYI, I made a simple attempt to support SASS modern API, and here's what I can offer.

I'm not sure what to do next, whether to continue offering the api options as I did in my attempt or wait for the stabilization of the sass modern api? Your constructive comments are welcome.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ygj6 ygj6 force-pushed the feat/issue-7116 branch from 5725b5e to b11bf7e Compare March 10, 2022 11:48
@patak-dev patak-dev added the p2-to-be-discussed Enhancement under consideration (priority) label Mar 11, 2022
@bluwy
Copy link
Member

bluwy commented Mar 12, 2023

We discussed this in the last team meeting. We're good with creating a new option to choose between legacy and modern approaches, but regarding

We would probably need the prev to have feature parity with the legacy approach. Looks like the issue linked is still open 😬

If there's a way around it however, we're happy to move forward with this if you're up to continuing this PR. Thanks for the first push to bring this on the table!

@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) needs rebase and removed p2-to-be-discussed Enhancement under consideration (priority) labels Sep 19, 2023
@bluwy
Copy link
Member

bluwy commented Sep 19, 2023

Looks like there's recent activity for sass/sass#3247 so that might be resolved soon. @ygj6 would you like to continue working on this soon? Feel free to close it too if not and we can track the progress at #7116

@danieka
Copy link

danieka commented Jan 30, 2024

@bluwy I'm very motivated to get this PR, or something like this, merged. We're using Vuetify, which in turn uses SASS, which is really slow. Can I help out with this PR? Is it too outdated to be able to merge? Would a contribution be welcome? I can't guarantee I'll get it done, but would like to take a crack at it.

@bluwy
Copy link
Member

bluwy commented Jan 31, 2024

@danieka feel free to open a new PR! We can then take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants