Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: rework
import.meta.glob
#7537feat!: rework
import.meta.glob
#7537Changes from 41 commits
60c1b78
7f8150e
c0601e3
b2e01cc
a7d83bb
df0d8a3
75c978e
2abd81c
147a8f4
86c3b97
2d61513
bf147a0
b592c3f
bfe527b
1ace8af
a2e557b
4ebd33a
d16ea81
5a4b87a
544961b
8f84137
a3d5325
e44a2b3
76fa2ea
1c1fbe3
b194219
bf771dd
1cd6f2d
a8b7e53
9637203
9779078
3c3c93b
d2c6104
1c6c295
ff22800
5f9388b
2294300
ceffc8c
f4a364c
50b762a
3fe2d5c
8ac8193
74c1e0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are multiple imports supported with an array? Should we add a section about this or maybe just use it in the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it does not support arrays. Referring to the
eager: true
example, the named import will be directly used as the value instead of the "Module" object. For multiple named imports they might better use multiple statements.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Sound good since most of the cases when using glob would require a single import, so looks good to me to wait until users request the feature. We could support both string or array if we need to go there anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, it would be good to avoid the name
query
since the way we add metadata/modifiers to imports is probably going to change in the future. But overridingas
to allow for multiple values doesn't sound future-proof, and any other more generic name may actually end up conflicting with whatever gets standardized in the end. I thought ofmetadata
,modifiers
,with
... we still have time until v3 to bike shed a bit if we find a more generic name that we are sure will not collide later. But for the moment, I think we can move forward withquery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess unless we are going to break our convention of using queries in v3.0, maybe naming it as
query
is still the most intuitive way to do it. In the future, if we find an alternative that does not use queries, (if it's not v3, probably v4) we could break this to align. It might be hard for now to foresee what's the format we gonna use in the future.