fix: inject esbuild helpers in IIFE and UMD wrappers #7948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p3-minor-bug
patak-dev
commented
Apr 29, 2022
This was referenced May 11, 2022
7 tasks
7 tasks
9 tasks
Closed
This was referenced Aug 10, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5426
fix #7188
Description
See #7188 (comment) for context.
We could search for a better solution later, but I think these issues are important enough that should be fixed even if it means injecting the esbuild helpers as a post processing as done in the PR.
What is the purpose of this pull request?