Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert #8025 and add missing "type": "module" #8060

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: revert #8025 and add missing "type": "module" #8060

merged 1 commit into from
May 11, 2022

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented May 7, 2022 •
edited
Loading

Description

Revert #8025

Additional context

Suggested in #8033 (comment)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann changed the title Revert #8025 fix: revert #8025 May 7, 2022
@benmccann benmccann changed the title fix: revert #8025 fix: revert #8025 and add missing "type": "module" May 7, 2022
@benmccann benmccann mentioned this pull request May 7, 2022
Closed
9 tasks
@benmccann benmccann force-pushed the rev-8025 branch 2 times, most recently from a5de058 to b6673fb Compare May 10, 2022 22:22
@patak-dev patak-dev merged commit c613f22 into vitejs:main May 11, 2022
@benmccann benmccann deleted the rev-8025 branch May 11, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygj6 ygj6 ygj6 left review comments

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @patak-dev @ygj6