docs: add Cloudflare Pages to deploy options #8927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bluwy
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Added some suggestions below. Make sure to run pnpm format too so the text is properly formatted, but otherwise my suggestions below should resolve the formatting too.
Question for the team: Are the deploy options ordered by first-come-first-serve or popularity? I think popularity might make sense as these guides are useful for new users. In that case I think Cloudflare Pages is in a perfect position in this PR, but maybe we also want to move Vercel up below Netlify (in another PR).
bluwy
changed the title
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
previously approved these changes
Jul 5, 2022
tony19
reviewed
Jul 5, 2022
Co-authored-by: Tony Trinh <tony19@gmail.com>
patak-dev
approved these changes
Jul 5, 2022
|
Thanks for reviewing this @bluwy. I think maybe we can move the question to an internal discussion or a GitHub issue so this PR can get merged |
Ekwuno
added a commit
to Ekwuno/vite
that referenced
this pull request
Jul 6, 2022
Ekwuno
added a commit
to Ekwuno/vite
that referenced
this pull request
Jul 6, 2022
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Cloudflare Pages to the Deployment options. Cloudflare Pages uses the Wrangler CLI to deploy application.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).