fix(scan): detect import .ts as .js #8969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-docs-main canceled.
|
patak-dev
reviewed
Jul 7, 2022
| const resolved = await resolve(id, importer) | ||
| const resolved = await resolve(id, importer, { | ||
| custom: { | ||
| depScan: { loader: pluginData?.htmlType?.loader } |
There was a problem hiding this comment.
We already have a scan flag that is available also to the resolver. But I agree that using the convention for custom here feels better. So looks good to me 👍🏼
patak-dev
approved these changes
Jul 7, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix sveltejs/kit#5387
After detecting the loader type for a html-ish file, pass this info to the
resolvePluginso we can resolve .ts as .jsWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).