Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports cts and mts files #9268

Merged
merged 7 commits into from
Jul 22, 2022
Merged

feat: supports cts and mts files #9268

merged 7 commits into from
Jul 22, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Jul 21, 2022

Description

Supports mts / cts in source files

closes #5201

Additional context

related PR: #8729

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz marked this pull request as ready for review July 21, 2022 06:55
@sapphi-red sapphi-red added enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority) labels Jul 21, 2022
bluwy
bluwy requested changes Jul 21, 2022
View reviewed changes
packages/vite/src/node/plugins/esbuild.ts Outdated Show resolved Hide resolved
packages/vite/src/node/utils.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev merged commit 0602017 into vitejs:main Jul 22, 2022
@sxzz sxzz deleted the feat/cts-mts-source branch July 22, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support mts and cts file
4 participants
@sxzz @patak-dev @bluwy @sapphi-red