fix: externalize explicitly configured linked packages #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p4-important
tony19
reviewed
Jul 24, 2022
|
vite-plugin-ssr is passing with this PR: And same for other CIs in the ecosystem, except for SvelteKit: @bluwy maybe you could check what is happening there? Also, if you have other ideas for this PR, please go ahead, I tried to keep the current structure for this fix. I still think we will need a refactoring in 3.1 |
bluwy
approved these changes
Jul 25, 2022
patak-dev
deleted the
fix/externalize-explicitily-configured-linked-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to:
After this PR, vite-plugin-ssr CI fails in vite-ecosystem-ci
When a package is explicitly configured as external, externalize it even if it is linked (it isn't in
node_modules).This PR also checks if a package is resolvable before externalizing it. I think this is more consistent between direct package imports and imports of package entries.
The PR also avoids returning undefined when calling
tryNodeResolvewith theexternalizeflag. Instead, it returns the resolved object, and in the ssr logic, we check for itsexternalflag.What is the purpose of this pull request?