Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vanilla classname small typo fix #9490

Closed
wants to merge 1 commit into from
Closed

Conversation

q1b
Copy link

@q1b q1b commented Aug 1, 2022

It's must be a typo,

Removed vanilla classname Causing, 👇

image

  • Typo fix

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@@ -8,7 +8,7 @@ document.querySelector<HTMLDivElement>('#app')!.innerHTML = `
<img src="/vite.svg" class="logo" alt="Vite logo" />
</a>
<a href="https://www.typescriptlang.org/" target="_blank">
<img src="${typescriptLogo}" class="logo vanilla" alt="TypeScript logo" />
<img src="${typescriptLogo}" class="logo" alt="TypeScript logo" />
Copy link
Contributor

@tony19 tony19 Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right change because removing .vanilla here would give the TypeScript logo the same purplish glow as Vite's logo. The style for .vanilla should be fixed IMO.

The actual color shown appears to be for the yellowish hue for the vanilla JavaScript logo, as seen in the scaffolded style:

.logo.vanilla:hover {
  filter: drop-shadow(0 0 2em #f7df1eaa);
}

And that's strange because the color is the correct bluish hue in:

.logo.vanilla:hover {
filter: drop-shadow(0 0 2em #3178c6aa);
}

That to me indicates the actual problem is create-vite is copying over template-vanilla's style.css file instead of the one from template-vanilla-ts.

@bluwy
Copy link
Member

bluwy commented Aug 2, 2022

The glow color should be blue-ish which is fixed at #9254 but not released yet. And yeah @tony19 is right that this isn't the right fix for now. I'll close this as it should be fixed when a new release is made.

@bluwy bluwy closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants