-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(legacy): remove code for Vite 2 #9640
Merged
patak-dev
merged 1 commit into
vitejs:main
from
sapphi-red:refactor/legacy-remove-vite2-support-code
Aug 11, 2022
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,19 +159,29 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] { | |
const legacyConfigPlugin: Plugin = { | ||
name: 'vite:legacy-config', | ||
|
||
apply: 'build', | ||
config(config) { | ||
if (!config.build) { | ||
config.build = {} | ||
config(config, env) { | ||
if (env.command === 'build') { | ||
if (!config.build) { | ||
config.build = {} | ||
} | ||
|
||
if (!config.build.cssTarget) { | ||
// Hint for esbuild that we are targeting legacy browsers when minifying CSS. | ||
// Full CSS compat table available at https://github.com/evanw/esbuild/blob/78e04680228cf989bdd7d471e02bbc2c8d345dc9/internal/compat/css_table.go | ||
// But note that only the `HexRGBA` feature affects the minify outcome. | ||
// HSL & rebeccapurple values will be minified away regardless the target. | ||
// So targeting `chrome61` suffices to fix the compatibility issue. | ||
config.build.cssTarget = 'chrome61' | ||
} | ||
} | ||
|
||
if (!config.build.cssTarget) { | ||
// Hint for esbuild that we are targeting legacy browsers when minifying CSS. | ||
// Full CSS compat table available at https://github.com/evanw/esbuild/blob/78e04680228cf989bdd7d471e02bbc2c8d345dc9/internal/compat/css_table.go | ||
// But note that only the `HexRGBA` feature affects the minify outcome. | ||
// HSL & rebeccapurple values will be minified away regardless the target. | ||
// So targeting `chrome61` suffices to fix the compatibility issue. | ||
config.build.cssTarget = 'chrome61' | ||
return { | ||
define: { | ||
'import.meta.env.LEGACY': | ||
env.command === 'serve' || config.build?.ssr | ||
? false | ||
: legacyEnvVarMarker | ||
} | ||
} | ||
} | ||
} | ||
|
@@ -547,41 +557,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] { | |
} | ||
} | ||
|
||
let envInjectionFailed = false | ||
const legacyEnvPlugin: Plugin = { | ||
name: 'vite:legacy-env', | ||
|
||
config(config, env) { | ||
if (env) { | ||
return { | ||
define: { | ||
'import.meta.env.LEGACY': | ||
env.command === 'serve' || config.build?.ssr | ||
? false | ||
: legacyEnvVarMarker | ||
} | ||
} | ||
} else { | ||
envInjectionFailed = true | ||
} | ||
}, | ||
|
||
configResolved(config) { | ||
if (envInjectionFailed) { | ||
config.logger.warn( | ||
`[@vitejs/plugin-legacy] import.meta.env.LEGACY was not injected due ` + | ||
`to incompatible vite version (requires vite@^2.0.0-beta.69).` | ||
) | ||
} | ||
} | ||
} | ||
|
||
return [ | ||
legacyConfigPlugin, | ||
legacyGenerateBundlePlugin, | ||
legacyPostPlugin, | ||
legacyEnvPlugin | ||
] | ||
return [legacyConfigPlugin, legacyGenerateBundlePlugin, legacyPostPlugin] | ||
} | ||
|
||
export async function detectPolyfills( | ||
|
@@ -667,8 +643,7 @@ async function buildPolyfillChunk( | |
}, | ||
output: { | ||
format, | ||
entryFileNames: rollupOutputOptions.entryFileNames, | ||
manualChunks: undefined | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed since vendor-split chunking strategy was removed in Vite 2.9. |
||
entryFileNames: rollupOutputOptions.entryFileNames | ||
} | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
envInjectionFailed
and merged intovite:legacy-config
plugin.