Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support custom css name by no cssCodesplit #9747

Closed
wants to merge 4 commits into from

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Aug 19, 2022

Description

fix: #4863
fix: #9732

Additional context

support custom css name by no cssCodesplit.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

I would consider this more as a fix for an unintentional regression that a feat. So I think we could merge this one and release it in a patch. @poyoho do you know how this broke in Vite 3?

I don't know if we should close #4863 though. At least we should discuss in a team meeting if this is going to be the way this feature is implemented and document it. Another option would be to expose a new config css.bundleName or something similar.

@poyoho poyoho changed the title feat: support custom css name by no cssCodesplit fix: support custom css name by no cssCodesplit Aug 19, 2022
@poyoho
Copy link
Member Author

poyoho commented Aug 19, 2022

may be I confuse what issues ask for. The issues ask for cssCodeSplit: false would output index.css. It mean style.css need to configureable. I think #4597 #4863 #9732 are ask for the same feature too.

And I checkout to 2.5.0, It seems not fix this problem.

@patak-dev
Copy link
Member

I'm a bit lost here. IIUC, this PR only adds a test case now and shows that #9732 wasn't an issue since the file name for style.css is correctly modified https://github.com/vitejs/vite/pull/9747/files#diff-903a4c1ecc75694a61c610989146d12e745eec8b85b6dded38930d5a71377bd8R26 ?

@poyoho
Copy link
Member Author

poyoho commented Aug 19, 2022

updated😁.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 19, 2023
@bluwy
Copy link
Member

bluwy commented May 18, 2024

In the meeting when we discussed this, we decided to re-use the library mode name as the CSS file name instead so we can avoid an option, but that would be for Vite 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

assetFileNames does not affect style Allow to specify filename of emitted CSS when build.cssCodeSplit: false
3 participants