Skip to content

Commit

Permalink
Throttler: verify deprecated flags are still allowed (#13615)
Browse files Browse the repository at this point in the history
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
  • Loading branch information
shlomi-noach authored Jul 31, 2023
1 parent b14aae6 commit 4748597
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions go/test/endtoend/onlineddl/revert/onlineddl_revert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ func TestMain(m *testing.M) {
"--migration_check_interval", "5s",
"--queryserver-config-schema-change-signal-interval", "0.1",
"--watch_replication_stream",
// The next flags are deprecated, and we incldue them to verify that they are nonetheless still allowed.
// The values are irrelevant. Just the fact that the flags are allowed in what's important.
// These should be included in v18, and removed in v19.
"--throttle_threshold", "1m",
"--throttle_metrics_query", "select 1 from dual",
"--throttle_metrics_threshold", "1.5",
"--throttle_check_as_check_self=false",
"--throttler-config-via-topo=true",
}
clusterInstance.VtGateExtraArgs = []string{
"--ddl_strategy", "online",
Expand Down

0 comments on commit 4748597

Please sign in to comment.