bugfix: check if options exist before using

Signed-off-by: Andres Taylor <andres@planetscale.com>
vitessio · Dec 17, 2024 · fbc3dbb · fbc3dbb
1 parent 5ada428
commit fbc3dbb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/go/vt/proto/query/query_extra.go b/go/vt/proto/query/query_extra.go
diff --git a/go/vt/vttablet/tabletserver/query_executor.go b/go/vt/vttablet/tabletserver/query_executor.go
@@ -1125,7 +1125,7 @@ func (qre *QueryExecutor) execDBConn(conn *connpool.Conn, sql string, wantfields
 	if err != nil {
 		return nil, err
 	}
-	if qre.options.FetchLastInsertId {
+	if qre.options.ShouldFetchLastInsertID() {
 		err := qre.fetchLastInsertID(ctx, conn, exec)
 		if err != nil {
 			return nil, err
@@ -1151,7 +1151,7 @@ func (qre *QueryExecutor) execStatefulConn(conn *StatefulConnection, sql string,
 	if err != nil {
 		return nil, err
 	}
-	if qre.options.FetchLastInsertId {
+	if qre.options.ShouldFetchLastInsertID() {
 		err = qre.fetchLastInsertID(ctx, conn.UnderlyingDBConn().Conn, exec)
 		if err != nil {
 			return nil, err