Backport: Backups: Support InnoDB Redo Log Location With 8.0.30+ #10895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kups ... removing the temporary workflow changes on main Backups: Support InnoDB Redo Log Location With 8.0.30+ Signed-off-by: Matt Lord <mattalord@gmail.com>
WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the golangci/golangci-lint#2649. go/mysql/conn_flaky_test.go:658:2: S1001: should use copy() instead of a loop (gosimple) for j, i := range t.queryPacket { ^ Signed-off-by: Matt Lord <mattalord@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
mattlord
added
Component: Backup and Restore
Type: Bug
Type: Enhancement
mattlord
requested review from
deepthi,
rohit-nayak-ps,
harshit-gangal and
systay
as code owners
mattlord
requested review from
GuptaManan100 and
rsajwani
and removed request for
systay,
harshit-gangal and
rohit-nayak-ps
mattlord
added a commit
to planetscale/vitess
that referenced
this pull request
Jul 31, 2022
This should not be merged until after the backport is merged: vitessio#10895 Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
This is needed as we do not currently plan on backporting the backup fixes to v13 and older, thus release-13.0 will not ever get the backup fixes to support 8.0.30+. If we do decide to backport the fixes to release-13.0 then this workflow change can be reverted. Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
added a commit
that referenced
this pull request
Aug 1, 2022
mattlord
force-pushed
the
backport-10847
branch
from
d58b30c to
5030cc2
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
GuptaManan100
approved these changes
Aug 2, 2022
3 tasks
3 tasks
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…essio#10895) (vitessio#911) Backups: Support InnoDB Redo Log Location With 8.0.30+ Signed-off-by: Matt Lord <mattalord@gmail.com> * Address linter warning: WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the golangci/golangci-lint#2649. go/mysql/conn_flaky_test.go:658:2: S1001: should use copy() instead of a loop (gosimple) for j, i := range t.queryPacket { ^ Signed-off-by: Matt Lord <mattalord@gmail.com>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #10847.
Related Issue(s)
Checklist