Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetFullStatus RPC to vtctld #10905

Merged
merged 6 commits into from
Aug 4, 2022
Merged

Add GetFullStatus RPC to vtctld #10905

merged 6 commits into from
Aug 4, 2022

Conversation

GuptaManan100
Copy link
Member

Description

This PR adds the GetFullStatus RPC to vtctld. This RPC exports the TabletManagerClient RPC FullStatus so it is possible to call it from the vtctld server.
This is required for VTAdmin to display the information provided by this RPC so that it can reach parity with the orchestrator UI.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100
test: add test for rpc
a12b472 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add getfullstatus rpc to vtctldserver
18fbe37 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
feat: add unit test for full status
acb8774 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management labels Aug 1, 2022
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 1, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

ajm188
ajm188 reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, just some nitpicks on the code organization to match existing stuff

go/cmd/vtctldclient/command/tablets.go Outdated Show resolved Hide resolved
go/test/endtoend/reparent/plannedreparent/reparent_test.go Outdated Show resolved Hide resolved
go/test/endtoend/reparent/plannedreparent/reparent_test.go Outdated Show resolved Hide resolved
go/vt/vtctl/grpcvtctldserver/server.go Show resolved Hide resolved
go/vt/vtctl/grpcvtctldserver/server_test.go Outdated Show resolved Hide resolved
go/vt/vtctl/grpcvtctldserver/testutil/test_tmclient.go Outdated Show resolved Hide resolved
go/vt/vtctl/grpcvtctldserver/testutil/test_tmclient.go Outdated Show resolved Hide resolved
@GuptaManan100
feat: fix sorting
f93a686 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 requested a review from ajm188 August 1, 2022 15:55
@GuptaManan100
refactor: fix ordering of commands in vtctldclient init function
4127ba9 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: move the full status test to newfeatures since old vtctld won't…
381a066 
… have this rpc

Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
GuptaManan100 commented Aug 3, 2022
View reviewed changes
Copy link
Member Author

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had to move the FullStatus test to newfeatures since the old vtctld don't have that RPC

deepthi
deepthi approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all feedback has been addressed. LGTM.
cc @ajm188

@deepthi deepthi merged commit 93bdc0e into vitessio:main Aug 4, 2022
@deepthi deepthi deleted the vtctld-full-status branch August 4, 2022 17:56
systay pushed a commit to planetscale/vitess that referenced this pull request Aug 19, 2022
@GuptaManan100 @deepthi
Merge pull request vitessio#10905 from planetscale/vtctld-full-status (…
119883f 
…vitessio#927)

Add GetFullStatus RPC to vtctld

Signed-off-by: Manan Gupta <manan@planetscale.com>

Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
@GuptaManan100 GuptaManan100 mentioned this pull request Sep 19, 2022
Closed
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request May 20, 2024
@deepthi @timvaillancourt
Merge pull request vitessio#10905 from planetscale/vtctld-full-status
c55d4d2 
Add GetFullStatus RPC to vtctld
@timvaillancourt timvaillancourt mentioned this pull request May 20, 2024
Merged
4 tasks
timvaillancourt added a commit to slackhq/vitess that referenced this pull request May 21, 2024
@timvaillancourt @deepthi
Merge pull request vitessio#10905 from planetscale/vtctld-full-status (…
8ce8799 
…#357)

Add GetFullStatus RPC to vtctld

Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@doeg doeg Awaiting requested review from doeg

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @deepthi @ajm188