Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade the Golang version to go1.20.2 #12706

Merged
merged 2 commits into from
Apr 3, 2023
Merged

[main] Upgrade the Golang version to go1.20.2 #12706

merged 2 commits into from
Apr 3, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 23, 2023 •
edited
Loading

This Pull Request bumps the Golang version to go1.20.2 and the bootstrap version to 16.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.2

@github-actions github-actions bot added Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base Skip CI Skip CI actions from running Type: CI/Build go labels Mar 23, 2023
@frouioui frouioui requested a review from systay as a code owner March 23, 2023 12:08
@frouioui
bump go version to go1.20.2
f4932ea 
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-main branch from 99489e0 to f4932ea Compare March 24, 2023 10:03
@frouioui frouioui removed the Skip CI Skip CI actions from running label Mar 24, 2023
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-main branch from eaf7728 to 969f1ae Compare March 25, 2023 00:22
@github-actions github-actions bot added the Skip CI Skip CI actions from running label Mar 25, 2023
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-main branch 6 times, most recently from 4a2ca58 to 6537cca Compare March 31, 2023 00:24
@frouioui frouioui mentioned this pull request Mar 31, 2023
Merged
4 tasks
@frouioui frouioui force-pushed the upgrade-go-to-1.20.2-on-main branch from 6537cca to eaf7728 Compare March 31, 2023 10:22
ajm188
ajm188 approved these changes Mar 31, 2023
View reviewed changes
docker/bootstrap/CHANGELOG.md Outdated Show resolved Hide resolved
@frouioui frouioui removed the Skip CI Skip CI actions from running label Mar 31, 2023
@frouioui frouioui force-pushed the upgrade-go-to-1.20.2-on-main branch from eaf7728 to dca363a Compare March 31, 2023 10:40
@github-actions github-actions bot added the Skip CI Skip CI actions from running label Apr 1, 2023
@github-actions github-actions bot force-pushed the upgrade-go-to-1.20.2-on-main branch 3 times, most recently from db66030 to 4948ec7 Compare April 3, 2023 00:23
@frouioui frouioui force-pushed the upgrade-go-to-1.20.2-on-main branch from 4948ec7 to dca363a Compare April 3, 2023 05:40
@frouioui frouioui removed the Skip CI Skip CI actions from running label Apr 3, 2023
@frouioui
Update workflows and docker error
5499f7b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.2-on-main branch from dca363a to 5499f7b Compare April 3, 2023 06:32
@frouioui frouioui merged commit 9e592d3 into main Apr 3, 2023
@frouioui frouioui deleted the upgrade-go-to-1.20.2-on-main branch April 3, 2023 08:02
@frouioui frouioui mentioned this pull request Apr 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajm188 @frouioui @GuptaManan100