Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky TestRestart: give mysqlctld process time to shutdown #12799

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Flaky TestRestart: give mysqlctld process time to shutdown #12799

merged 2 commits into from
Apr 3, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

TestRestart is flaky. The mysqlctld process is first stopped and then restarted. However the restart finds that the process teardown has not been fully complete.

Adding a wait, in case there is a contributing delay in CI between the time the process is stopped and the mysqlctld goroutine actually gets the signal and is scheduled to terminate.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 31, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 31, 2023 •
edited by GuptaManan100
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rohit-nayak-ps rohit-nayak-ps added Type: Bug Component: Cluster management Flakes and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Mar 31, 2023
@rohit-nayak-ps
Give mysqlctld time to shutdown properly before restarting to account…
5a1cc77 
… for delays in CI

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review April 1, 2023 10:00
@rohit-nayak-ps rohit-nayak-ps requested a review from deepthi as a code owner April 1, 2023 10:00
@rohit-nayak-ps
Copy link
Contributor Author

TestRestart ran 5 times in a row. Hopefully this will fix the CI flakiness.

@rohit-nayak-ps
Address review comments
1c693d9 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps merged commit 8e9cd3b into vitessio:main Apr 3, 2023
@rohit-nayak-ps rohit-nayak-ps deleted the rn-flaky-TestRestart branch April 3, 2023 08:59
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Apr 3, 2023

I was unable to backport this Pull Request to the following branches: release-16.0.

rohit-nayak-ps added a commit to planetscale/vitess that referenced this pull request Apr 3, 2023
@rohit-nayak-ps
Flaky TestRestart: give mysqlctld process time to shutdown (vitessio#…
a8f474a 
…12799)

* Give mysqlctld time to shutdown properly before restarting to account for delays in CI

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rsajwani
rsajwani reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@rsajwani rsajwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsajwani rsajwani mentioned this pull request Apr 5, 2023
Merged
4 tasks
rohit-nayak-ps added a commit that referenced this pull request Apr 6, 2023
@rohit-nayak-ps @vmg
Move vreplication to vitess json parser (#12761)
e1be0c7 
* Initial commit. Added json support to tracked buffer. Moved FormatFloat and replication constants required for json parser into sqltypes. Currently has import cycles due to use of CellAlias in json parser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Also add code to move vstreamer-side json binlog parser to use the new vitess json parser

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* mysql: extract binlog package

Signed-off-by: Vicent Marti <vmg@strn.cat>

* add missing license

Signed-off-by: Vicent Marti <vmg@strn.cat>

* Use Vitess json parser in VStreamer VEvents and VReplication DMLs. Store json values in a lossless manner using JSON_OBJECT/JSON_ARRAYs

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Remove unused code incorrectly added to TrackedBuffer

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Add table with json columns and multiple rows with a bunch of json strings as part of all vrep e2e tests

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Add json_tbl to second customer vschema

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Flaky TestRestart: give mysqlctld process time to shutdown (#12799)

* Give mysqlctld time to shutdown properly before restarting to account for delays in CI

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Add e2e tests for geometry columns. Make geometry byte comparable to fix vdiff failure

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Add tests with nested json docs. Remove GEOMETRY from TestConsistentLookupUpdateBecauseUncomparableTypes

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix expected json value for TestMessage to account for the additional space b/w key and value added by the new serialization

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: Vicent Marti <vmg@strn.cat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsajwani rsajwani rsajwani left review comments

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Flakes Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohit-nayak-ps @mattlord @rsajwani @frouioui @GuptaManan100