-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Upgrade the Golang version to go1.20.3
#12833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
github-actions
bot
requested review from
GuptaManan100,
frouioui,
rohit-nayak-ps,
deepthi,
mattlord,
harshit-gangal and
derekperkins
as code owners
April 5, 2023 00:20
github-actions
bot
added
Component: General
Changes throughout the code base
go
Skip CI
Skip CI actions from running
Type: CI/Build
labels
Apr 5, 2023
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
labels
Apr 5, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
frouioui
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
Skip CI
Skip CI actions from running
labels
Apr 5, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
upgrade-go-to-1.20.3-on-main
branch
from
April 5, 2023 12:24
abb140e
to
28ac032
Compare
frouioui
approved these changes
Apr 5, 2023
github-actions
bot
force-pushed
the
upgrade-go-to-1.20.3-on-main
branch
from
April 6, 2023 00:22
28ac032
to
b2e5de3
Compare
frouioui
force-pushed
the
upgrade-go-to-1.20.3-on-main
branch
from
April 6, 2023 07:58
b2e5de3
to
28ac032
Compare
…on-main Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
mattlord
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
go
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request bumps the Golang version to
go1.20.3
and the bootstrap version to17
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.3