Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #13075

WilliamLu99 · 2023-05-11T17:43:03Z

Re-opening my PR under my own account, as I no longer have access to the Shopify/Vitess repo after being impacted by their layoffs.

This PR also fixes the two failing checks in the original PR.

Description

Fixes a bug where ChangeTabletType would fail on clusters that don't have rpl_semi_sync_master and rpl_semi_sync_slave plugins loaded. Does so by refactoring the convertBoolToSemiSyncAction method to return SemiSyncActionNone if the plugin is not loaded. To do this, we query the underlying mysql to check if the rpl_semi_sync_% variables are present.

This bug is only present from v15 onwards, so a backport might be in order to fix v15.

Related Issue(s)

Fixes #12869

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

Deployment Notes

vitess-bot · 2023-05-11T17:43:06Z

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

Ensure that the Pull Request has a descriptive title.
If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

Is it really necessary to add this flag?
Flag names should be clear and intuitive (as far as possible)
Help text should be descriptive.
Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

Each item in Jobs should be named in order to mark it as required.
If the workflow should be required, the maintainer team should be notified.

Bug fixes

There should be at least one unit or end-to-end test.
The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

There should be some code comments as to why things are implemented the way they are.

New/Existing features

Should be documented, either by modifying the existing documentation or creating new documentation.
New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

Protobuf changes should be wire-compatible.
Changes to _vt tables and RPCs need to be backward compatible.
vtctl command output order should be stable and awk-able.
RPC changes should be compatible with vitess-operator
If a flag is removed, then it should also be removed from VTop, if used there.

GuptaManan100

Everything else LGTM!

GuptaManan100 · 2023-05-12T05:05:28Z

go/vt/vttablet/tabletmanager/rpc_actions.go

+		}
+	} else {
+		if semiSync {
+			return SemiSyncActionNone, errors.New("semi-sync plugins are not loaded.")


We should make this into a vterrors.VitessError instead. That package has a lot of error definitions for Vitess errors not originating from MySQL. We should add one more there. The reason we do this is because we get the correct grpc code if we use those errors.

We should create something like this -

VT09013 = errorWithoutState("VT09013", vtrpcpb.Code_FAILED_PRECONDITION, "semi-sync plugins are not loaded", "Durability policy wants Vitess to use semi-sync, but the MySQL instances don't have the semi-sync plugin loaded")

and use that instead.

Oooo good suggestion! I like it.

…ctions Signed-off-by: William Lu <william.lu@shopify.com>

Signed-off-by: William Lu <william@tamedfox.ca>

GuptaManan100

Love it!

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>

arthurschreiber · 2023-09-08T17:35:03Z

We have a similar setup (semi sync is disabled, plugins are not loaded), and this bug prevents us from using PlannedReparentShard. I'm going to attach backport labels to v15 and v16 - let's see if that'll work.

…actions (vitessio#13075) * Fix convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: William Lu <william.lu@shopify.com> Signed-off-by: William Lu <william@tamedfox.ca>

…actions (vitessio#13075) * Fix convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: William Lu <william.lu@shopify.com> * Add VitessError VT09013 Signed-off-by: William Lu <william@tamedfox.ca> --------- Signed-off-by: William Lu <william.lu@shopify.com> Signed-off-by: William Lu <william@tamedfox.ca> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>

…actions (vitessio#13075) * Fix convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: William Lu <william.lu@shopify.com> Signed-off-by: William Lu <william@tamedfox.ca> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>

… all semi sync actions (#13075) (#13958) Signed-off-by: William Lu <william.lu@shopify.com> Signed-off-by: William Lu <william@tamedfox.ca> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: William Lu <31415453+WilliamLu99@users.noreply.github.com>

… all semi sync actions (#13075) (#13957) Co-authored-by: William Lu <william@tamedfox.ca>

WilliamLu99 requested review from deepthi, GuptaManan100, rohit-nayak-ps, shlomi-noach, mattlord and ajm188 as code owners May 11, 2023 17:43

vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 11, 2023

github-actions bot added this to the v17.0.0 milestone May 11, 2023

WilliamLu99 mentioned this pull request May 11, 2023

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #12914

Closed

4 tasks

GuptaManan100 reviewed May 12, 2023

View reviewed changes

GuptaManan100 added Type: Bug Component: Cluster management and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels May 12, 2023

WilliamLu99 requested review from harshit-gangal and systay as code owners May 12, 2023 14:31

WilliamLu99 force-pushed the ignore-semisync-if-plugin-unloaded branch from f872c96 to 977b7ab Compare May 12, 2023 14:32

vitess-bot bot mentioned this pull request May 12, 2023

Update error code documentation (#13075) vitessio/website#1469

Closed

WilliamLu99 and others added 2 commits May 12, 2023 10:32

Fix convertBoolToSemiSyncAction method to account for all semi sync a…

77b2dd4

…ctions Signed-off-by: William Lu <william.lu@shopify.com>

Add VitessError VT09013

7405874

Signed-off-by: William Lu <william@tamedfox.ca>

WilliamLu99 force-pushed the ignore-semisync-if-plugin-unloaded branch from 977b7ab to 7405874 Compare May 12, 2023 14:34

WilliamLu99 requested a review from GuptaManan100 May 12, 2023 14:35

shlomi-noach approved these changes May 15, 2023

View reviewed changes

GuptaManan100 approved these changes May 17, 2023

View reviewed changes

GuptaManan100 removed the NeedsWebsiteDocsUpdate What it says label May 17, 2023

GuptaManan100 merged commit d95cffd into vitessio:main May 17, 2023

brendar pushed a commit to Shopify/vitess that referenced this pull request Jun 16, 2023

Backport vitessio#13075

a4b6c89

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>

brendar mentioned this pull request Jun 16, 2023

Use upstream convert bool to semi sync action fix Shopify/vitess#103

Merged

brendar pushed a commit to Shopify/vitess that referenced this pull request Jun 20, 2023

Backport vitessio#13075

14548d2

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>

austenLacy mentioned this pull request Aug 1, 2023

Custom jwt http ACL policy Shopify/vitess#114

Closed

arthurschreiber added Backport to: release-15.0 labels Sep 8, 2023

arthurschreiber mentioned this pull request Sep 8, 2023

Backport semi-sync fixes github/vitess-gh#69

Closed

arthurschreiber mentioned this pull request Sep 12, 2023

[release-15.0] Fix: convertBoolToSemiSyncAction method to account for all semi sync actions (#13075) #13957

Merged

4 tasks

arthurschreiber mentioned this pull request Sep 12, 2023

[release-16.0] Fix: convertBoolToSemiSyncAction method to account for all semi sync actions (#13075) #13958

Merged

4 tasks

frouioui pushed a commit that referenced this pull request Sep 20, 2023

[release-15.0] Fix: convertBoolToSemiSyncAction method to account for…

ebbf009

… all semi sync actions (#13075) (#13957) Co-authored-by: William Lu <william@tamedfox.ca>

hmaurer mentioned this pull request Mar 21, 2024

oops #15542

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #13075

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #13075

WilliamLu99 commented May 11, 2023 •

edited

Loading

vitess-bot bot commented May 11, 2023

GuptaManan100 left a comment

GuptaManan100 May 12, 2023 •

edited by deepthi

Loading

WilliamLu99 May 12, 2023

GuptaManan100 left a comment

arthurschreiber commented Sep 8, 2023

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #13075

Fix: convertBoolToSemiSyncAction method to account for all semi sync actions #13075

Conversation

WilliamLu99 commented May 11, 2023 • edited Loading

Description

Related Issue(s)

Checklist

Deployment Notes

vitess-bot bot commented May 11, 2023

Review Checklist

General

If a new flag is being introduced:

If a workflow is added or modified:

Bug fixes

Non-trivial changes

New/Existing features

Backward compatibility

GuptaManan100 left a comment

Choose a reason for hiding this comment

GuptaManan100 May 12, 2023 • edited by deepthi Loading

Choose a reason for hiding this comment

WilliamLu99 May 12, 2023

Choose a reason for hiding this comment

GuptaManan100 left a comment

Choose a reason for hiding this comment

arthurschreiber commented Sep 8, 2023

WilliamLu99 commented May 11, 2023 •

edited

Loading

GuptaManan100 May 12, 2023 •

edited by deepthi

Loading