-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove additional unused Dockerfile entries #13344
Conversation
The `docker/k8s` directory also seems to trace back to when Helm was still a thing. It also doesn't actually have a `vtorc` container which indicates it's not actually used since `vtorc` is actually required these days. From the looks of it, the same applies to `docker/mini` and that is unused as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Ah, I don't have access to those Docker stats. |
Closing this as we do seem to publish |
Opened #13347 for the cleanup TODO that we can fix now. |
The
docker/k8s
directory also seems to trace back to when Helm was still a thing. It also doesn't actually have avtorc
container which indicates it's not actually used sincevtorc
is actually required these days.From the looks of it, the same applies to
docker/mini
and that is unused as well.Related Issue(s)
Found when looking at pending comments for #3553
Checklist