Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-17.0] Upgrade-downgrade test fix: Remove throttler flags in vttablet-up.sh #13516

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

GuptaManan100
Copy link
Member

@GuptaManan100 GuptaManan100 commented Jul 17, 2023

Description

The flags that are used in release-17.0 namely throttler-config-via-topo doesn't exist on main post the changes in #13246. This PR removes these flags in vttablet-up.sh so as to fix the failing upgrade-downgrade tests.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 added Type: Testing Component: General Changes throughout the code base labels Jul 17, 2023
@GuptaManan100 GuptaManan100 requested a review from deepthi as a code owner July 17, 2023 06:10
@github-actions github-actions bot added this to the v17.0.1 milestone Jul 17, 2023
@GuptaManan100 GuptaManan100 changed the title Upgrade-downgrade test fix: Remove throttler flags in vttablet-up.sh [release-17.0] Upgrade-downgrade test fix: Remove throttler flags in vttablet-up.sh Jul 17, 2023
@GuptaManan100 GuptaManan100 added Component: General Changes throughout the code base and removed Component: General Changes throughout the code base labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants