-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-16.0] VReplication: Ensure ROW events are sent within a transaction (#13547) #13580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitess-bot
bot
added
Backport
This is a backport
Component: VReplication
Merge Conflict
Skip CI
Skip CI actions from running
Type: Bug
labels
Jul 20, 2023
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Hello @mattlord, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jul 20, 2023
vitess-bot
bot
requested review from
harshit-gangal,
mattlord,
shlomi-noach and
systay
July 20, 2023 16:57
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
Skip CI
Skip CI actions from running
NeedsIssue
A linked issue is missing for this Pull Request
Merge Conflict
labels
Jul 21, 2023
mattlord
force-pushed
the
backport-13547-to-release-16.0
branch
from
July 21, 2023 13:39
c70970c
to
f29794d
Compare
mattlord
force-pushed
the
backport-13547-to-release-16.0
branch
from
July 21, 2023 13:43
f29794d
to
74ca2d5
Compare
mattlord
approved these changes
Jul 21, 2023
mattlord
force-pushed
the
backport-13547-to-release-16.0
branch
from
July 21, 2023 13:53
74ca2d5
to
9df4a26
Compare
rohit-nayak-ps
approved these changes
Jul 21, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
backport-13547-to-release-16.0
branch
from
July 21, 2023 15:13
9df4a26
to
bea9758
Compare
arthurschreiber
pushed a commit
to github/vitess-gh
that referenced
this pull request
Jul 26, 2023
…io#13547) (vitessio#13580) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #13547