-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Upgrade the Golang version to go1.20.7
#13682
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
github-actions
bot
requested review from
GuptaManan100,
frouioui and
rohit-nayak-ps
as code owners
August 2, 2023 00:23
github-actions
bot
added
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
labels
Aug 2, 2023
github-actions
bot
requested review from
harshit-gangal,
derekperkins and
dkhenry
as code owners
August 2, 2023 00:23
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Aug 2, 2023
3 tasks
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
github-actions
bot
added
the
Stale
Marks PRs as stale after a period of inactivity, which are then closed after a grace period.
label
Sep 7, 2023
Closing this PR as it is a duplicate of #13933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Benchmark me
Add label to PR to run benchmarks
Component: General
Changes throughout the code base
go
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
Skip CI
Skip CI actions from running
Stale
Marks PRs as stale after a period of inactivity, which are then closed after a grace period.
Type: CI/Build
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request bumps the Golang version to
go1.20.7
and the bootstrap version to20
.There are a few manual steps remaining:
./.github/workflows/*.yml
files with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.7