Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Improve MoveTables Create Error Handling #13737

Merged
merged 22 commits into from
Aug 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5a908cf
MoveTables: don't create routing rules until after streams
mattlord Aug 7, 2023
e478ab2
Add vtctlclient unit test (that fails on main)
mattlord Aug 7, 2023
d200fd7
Improve comment
mattlord Aug 7, 2023
637ba76
Pedantic cleanup
mattlord Aug 8, 2023
a1dd8e1
Minor changes after self review
mattlord Aug 8, 2023
411f2fe
Stop using t.Fatal in new tests
mattlord Aug 8, 2023
d0d0f28
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord Aug 9, 2023
b47fe10
Add vtctldclient unit test
mattlord Aug 10, 2023
d7360b8
Automatically clean up on MoveTables Create error
mattlord Aug 14, 2023
83f5938
Add missing else in workflow server
mattlord Aug 14, 2023
3c381c4
Restore original logic
mattlord Aug 14, 2023
ed1beae
Add named return values for workflow case
mattlord Aug 14, 2023
fe4a51e
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord Aug 15, 2023
d98416f
Improve vtctldclient unit test
mattlord Aug 15, 2023
5741fcf
Minor tweaks
mattlord Aug 15, 2023
982bc2f
Minor formatting improvements
mattlord Aug 15, 2023
f0713ee
Must stop nitting...
mattlord Aug 15, 2023
e3fc307
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord Aug 16, 2023
1da742b
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord Aug 20, 2023
24d8332
Don't fail e2e workflow if schema tracker is slow
mattlord Aug 20, 2023
80f8a03
Turns out that WorkflowDelete isn't the right fit
mattlord Aug 20, 2023
dc2742f
Address review comment
mattlord Aug 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/test/endtoend/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func AssertMatchesWithTimeout(t *testing.T, conn *mysql.Conn, query, expected st

// WaitForAuthoritative waits for a table to become authoritative
func WaitForAuthoritative(t *testing.T, ks, tbl string, readVSchema func() (*interface{}, error)) error {
timeout := time.After(10 * time.Second)
timeout := time.After(60 * time.Second)
Copy link
Contributor Author

@mattlord mattlord Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is addressing an unrelated cause of test flakiness that was seen.

for {
select {
case <-timeout:
Expand Down