-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Improve MoveTables Create Error Handling #13737
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5a908cf
MoveTables: don't create routing rules until after streams
mattlord e478ab2
Add vtctlclient unit test (that fails on main)
mattlord d200fd7
Improve comment
mattlord 637ba76
Pedantic cleanup
mattlord a1dd8e1
Minor changes after self review
mattlord 411f2fe
Stop using t.Fatal in new tests
mattlord d0d0f28
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord b47fe10
Add vtctldclient unit test
mattlord d7360b8
Automatically clean up on MoveTables Create error
mattlord 83f5938
Add missing else in workflow server
mattlord 3c381c4
Restore original logic
mattlord ed1beae
Add named return values for workflow case
mattlord fe4a51e
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord d98416f
Improve vtctldclient unit test
mattlord 5741fcf
Minor tweaks
mattlord 982bc2f
Minor formatting improvements
mattlord f0713ee
Must stop nitting...
mattlord e3fc307
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord 1da742b
Merge remote-tracking branch 'origin/main' into movetables_routing
mattlord 24d8332
Don't fail e2e workflow if schema tracker is slow
mattlord 80f8a03
Turns out that WorkflowDelete isn't the right fit
mattlord dc2742f
Address review comment
mattlord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressing an unrelated cause of test flakiness that was seen.