Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-17.0] Upgrade the Golang version to go1.20.8 #13934

Merged
merged 3 commits into from
Sep 8, 2023
Merged

[release-17.0] Upgrade the Golang version to go1.20.8 #13934

merged 3 commits into from
Sep 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2023 •
edited by frouioui
Loading

This Pull Request bumps the Golang version to go1.20.8 and the bootstrap version to 18.2.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.8

@frouioui
bump go version to go1.20.8
1fa4d31 
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added the Benchmark me Add label to PR to run benchmarks label Sep 7, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 7, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added the Component: General Changes throughout the code base label Sep 7, 2023
@github-actions github-actions bot requested a review from deepthi as a code owner September 7, 2023 00:20
@github-actions github-actions bot added the go label Sep 7, 2023
@github-actions github-actions bot requested a review from mattlord as a code owner September 7, 2023 00:20
@github-actions github-actions bot added Skip CI Skip CI actions from running Type: CI/Build labels Sep 7, 2023
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 7, 2023
@frouioui frouioui mentioned this pull request Sep 7, 2023
Closed
3 tasks
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 7, 2023
@frouioui
bump golang version used in the GHA workflows to go1.20.8
6abf0f7 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed the Skip CI Skip CI actions from running label Sep 7, 2023
@frouioui frouioui added this to the v17.0.3 milestone Sep 7, 2023
@frouioui
bump upgrade tests to go1.21.1
d0e0931 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.8-on-release-17.0 branch from e5a97d8 to d0e0931 Compare September 7, 2023 22:29
deepthi
deepthi approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please address the comment.

build.env
@@ -17,7 +17,7 @@
source ./tools/shell_functions.inc

go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.5 || echo "Go version reported: `go version`. Version 1.20.5+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.8 || echo "Go version reported: `go version`. Version 1.20.8+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to require the minor version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not required it's recommended

@deepthi deepthi mentioned this pull request Sep 8, 2023
Merged
4 tasks
@frouioui frouioui merged commit ccbb4ad into release-17.0 Sep 8, 2023
@frouioui frouioui deleted the upgrade-go-to-1.20.8-on-release-17.0 branch September 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi deepthi approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build
Projects
None yet
Milestone
v17.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthi @frouioui