Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 16.0]: Online DDL: timeouts for all gRPC calls (#14182) #14191

Merged

Conversation

shlomi-noach
Copy link
Contributor

Backport of #14182 to release-16.0

Description

Following the same lines of how #14165 solves #14164, this PR ensures there's reasonable timeout s for any gRPC call made by the Online DDL service.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Bug Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Oct 5, 2023
@shlomi-noach shlomi-noach requested a review from a team October 5, 2023 10:26
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 5, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v16.0.6 milestone Oct 5, 2023
@shlomi-noach shlomi-noach requested a review from a team October 10, 2023 09:32
@rohit-nayak-ps rohit-nayak-ps merged commit 745ed3f into vitessio:release-16.0 Oct 11, 2023
113 of 114 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the onlineddl-grpc-timeouts-16.0 branch October 11, 2023 08:57
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants