Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Online DDL foreign key support (also in vtgate stress tests) when backing MySQL includes appropriate patch #14370

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Oct 26, 2023

Description

As explained in https://vitess.io/blog/2021-06-15-online-ddl-why-no-fk/, Online DDL cannot work with vanilla MySQL.

However, this patch, as part of this public fork, modifies MySQL as follows:

  • Adds a rename_table_preserve_foreign_key global/session boolean variable (defaults false/0 for backwards compatibility).
  • When enabled, a RENAME TABLES statement that replaces two tables Online-DDL-style, pins any children tables' foreign keys to the table name rather than the table pointer. Meaning after the RENAME, the children point to the new table that is using the original table name, rather than migrating along with the old table. This supports Online DDL for parent tables.
  • Regardless of the variable, foreign key checks are ignored for any table that uses an internal vitess name (i.e. Online DDL vreplication tables, GC tables), whether parent-side or child-side. It's as if FOREIGN_KEY_CHECKS=0 for those specific tables. This supports Online DDL for children tables.

In this PR:

  • Online DDL executor looks for the rename_table_preserve_foreign_key variable. If present, that means Online DDL ALTER TABLE is possible in vitess strategy.
  • Executor validates existence of the variable before embarking on a foreign-key enabled migration. It also sets rename_table_preserve_foreign_key to 1 for the cut-over process (MySQL needs to prove it supports the variable at the beginning and at the end of a migration).
  • VTGate FK stress tests now enable Online DDL when the backing MySQL server supports rename_table_preserve_foreign_key.

Note that https://github.com/vitessio/vitess uses vanilla MySQL in its CI workflows. Therefore, the changes made to the endtoend tests in this PR won't actually run in GitHub CI for this repo. The changes are stress tested (as part of any pull request) inside PlanetScale (developers of this patch) using aforementioned MySQL patch.

As a reminder, one still must use --unsafe-allow-foreign-keys DDL strategy when affected tables participate in FK constraint relationship.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
- Check for 'rename_table_preserve_foreign_key' variable
- Concurrency based on num CPUs
- additional tests: add FK, drop FK

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…hen appropriate

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Oct 26, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 26, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 26, 2023
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request labels Oct 26, 2023
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Oct 26, 2023

onlineddl_scheduler test failures are legit and due to how we now error out when a migration is requested to --unsafe-allow-foreign-keys without an appropriate backing MySQL capability.

fixed

…n_key'

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach removed the NeedsWebsiteDocsUpdate What it says label Oct 26, 2023
@shlomi-noach shlomi-noach merged commit dab068e into vitessio:main Oct 30, 2023
115 of 116 checks passed
@shlomi-noach shlomi-noach deleted the vtgate-fk-stress-onlineddl branch October 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants