Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlparser: Use KEY instead of INDEX for normalized form #14416

Merged
merged 1 commit into from
Nov 1, 2023
Merged

sqlparser: Use KEY instead of INDEX for normalized form #14416

merged 1 commit into from
Nov 1, 2023

Conversation

dbussink
Copy link
Contributor

@dbussink dbussink commented Nov 1, 2023

This matches how MySQL behaves for example in SHOW CREATE TABLE. This is the kind of output format we want to match if we reasonably can, also to simplify and schemadiff more friendly to use.

Related Issue(s)

Behavior changed in #14177 but I don't think we want this specific change from that refactor.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 1, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 1, 2023
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 1, 2023
vmg
vmg approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalizing in either direction is fine. Whatever causes fewer conflicts with Singularity! 👌

@dbussink dbussink force-pushed the dbussink/keep-key-name branch from 06c5990 to 9afa5d5 Compare November 1, 2023 09:18
@dbussink dbussink force-pushed the dbussink/keep-key-name branch from 9afa5d5 to c4252a9 Compare November 1, 2023 09:52
@dbussink
sqlparser: Use KEY instead of INDEX for normalized form
e5d5910 
This matches how MySQL behaves for example in `SHOW CREATE TABLE`. This
is the kind of output format we want to match if we reasonably can, also
to simplify and `schemadiff` more friendly to use.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/keep-key-name branch from c4252a9 to e5d5910 Compare November 1, 2023 10:17
@dbussink dbussink merged commit 71d6d0e into vitessio:main Nov 1, 2023
115 checks passed
@dbussink dbussink deleted the dbussink/keep-key-name branch November 1, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@vmg vmg vmg approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Component: Query Serving Type: Internal Cleanup
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dbussink @vmg @shlomi-noach @harshit-gangal @GuptaManan100