Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestStreamMigrateMainflow: fix panic in test #14420

Merged
merged 1 commit into from
Nov 1, 2023
Merged

TestStreamMigrateMainflow: fix panic in test #14420

merged 1 commit into from
Nov 1, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

The test environment was not being properly initialized resulting in panics related to vdiff goroutines. This was not relevant to the test and not failing the tests, but the panics were being logged.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Fix panic in TestStreamMigrateMainflow
0e0dbeb 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 1, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 1, 2023
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 1, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 1, 2023
@rohit-nayak-ps rohit-nayak-ps requested a review from a team November 1, 2023 16:22
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review November 1, 2023 16:22
dbussink
dbussink reviewed Nov 1, 2023
View reviewed changes
go/vt/wrangler/fake_tablet_test.go
@@ -23,6 +23,9 @@ import (
"testing"
"time"

vdiff2 "vitess.io/vitess/go/vt/vttablet/tabletmanager/vdiff"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a type vdiff defined in wrangler

@rohit-nayak-ps rohit-nayak-ps merged commit 3037acd into vitessio:main Nov 1, 2023
119 of 120 checks passed
@rohit-nayak-ps rohit-nayak-ps deleted the rohit/TestStreamMigrateMainflow branch November 1, 2023 17:48
@rohit-nayak-ps rohit-nayak-ps mentioned this pull request Nov 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink left review comments

@mattlord mattlord mattlord approved these changes

@deepthi deepthi deepthi approved these changes

Assignees
No one assigned
Labels
Component: VReplication Type: Testing
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rohit-nayak-ps @dbussink @deepthi @mattlord