-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make column resolution closer to MySQL #14426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
November 2, 2023 07:48
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 2, 2023
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 2, 2023
dbussink
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice little fix!
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Nov 2, 2023
This was referenced Nov 2, 2023
systay
added a commit
that referenced
this pull request
Nov 6, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
4 tasks
4 tasks
harshit-gangal
pushed a commit
that referenced
this pull request
Nov 10, 2023
systay
added a commit
that referenced
this pull request
Nov 10, 2023
deepthi
pushed a commit
that referenced
this pull request
Nov 10, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>
Merged
4 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our column resolution logic to make it closer to what MySQL does. We want to allow this type of query:
MySQL correctly understands that
foo
here is pointing tou.foo
and nothing else, but Vitess would not always make this connection. As part of this change, we also check for ambiguous columns and will fail some queries that MySQL also fails, but would be accepted by earlier releases of Vitess.Backports of this PR should not fail ambiguous columns - we don't want to start failing queries in a patch release.
Related Issue(s)
Fixes #14067
Checklist