-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planbuilder: push down ordering through filter #14583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Query Serving
labels
Nov 22, 2023
systay
requested review from
harshit-gangal,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
November 22, 2023 14:13
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 22, 2023
systay
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 22, 2023
dbussink
approved these changes
Nov 22, 2023
frouioui
approved these changes
Nov 22, 2023
harshit-gangal
approved these changes
Nov 22, 2023
vitess-bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui
pushed a commit
that referenced
this pull request
Nov 23, 2023
#14584) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When decided what should be pushed under what, we made a mistake.
The thinking was that if we need to filter and order the results, we should filter first so we have less to order. For that reason we didn't push ordering under filtering.
Unfortunately, this means that we forced the sorting to happen on the vtgate side, which means that we have to have the full result set before we can sort it, and that can easily lead to OOMs.
Here we are allowing the ordering to be pushed down under the route, which means that MySQL is producing ordered results. These can be merged together one chunk at a time, thanks to the pre-sorting.
Related Issue(s)
Checklist