Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planbuilder: push down ordering through filter #14583

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

systay
Copy link
Collaborator

@systay systay commented Nov 22, 2023

Description

When decided what should be pushed under what, we made a mistake.
The thinking was that if we need to filter and order the results, we should filter first so we have less to order. For that reason we didn't push ordering under filtering.

Unfortunately, this means that we forced the sorting to happen on the vtgate side, which means that we have to have the full result set before we can sort it, and that can easily lead to OOMs.

Here we are allowing the ordering to be pushed down under the route, which means that MySQL is producing ordered results. These can be merged together one chunk at a time, thanks to the pre-sorting.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels Nov 22, 2023
Copy link
Contributor

vitess-bot bot commented Nov 22, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 22, 2023
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 22, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 22, 2023
@harshit-gangal harshit-gangal merged commit 2d0c9c1 into vitessio:main Nov 22, 2023
119 of 120 checks passed
@harshit-gangal harshit-gangal deleted the push-down-ordering branch November 22, 2023 15:24
vitess-bot pushed a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui pushed a commit that referenced this pull request Nov 23, 2023
#14584)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants