Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: Fix workflow filtering in GetWorkflows RPC #15524

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Mar 19, 2024

Description

This is a follow-up to the work done in #14424 where we moved reads against the vreplication table away from client side generated SQL to typed client-server RPCs (the server then builds the appropriate SELECT against the underlying table).

As part of that work, I errantly always included a workflow include filter in the new RPC request. The result of that is when you want to get/list all workflows, rather than just one, you get no results as the include workflow name filter is '' — meaning only include workflows where the name is empty.

This PR corrects that and adds tests for vtctldclient based "workflow list" related commands.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Signed-off-by: Matt Lord <mattalord@gmail.com>
Copy link
Contributor

vitess-bot bot commented Mar 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 19, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 19, 2024
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (d20f3c5) to head (d92bbdf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15524      +/-   ##
==========================================
+ Coverage   65.71%   65.72%   +0.01%     
==========================================
  Files        1560     1560              
  Lines      194484   194485       +1     
==========================================
+ Hits       127798   127824      +26     
+ Misses      66686    66661      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord changed the title VReplication: Fix workflow filtering in GetWorkflows VReplication: Fix workflow filtering in GetWorkflows RPC Mar 20, 2024
@mattlord mattlord marked this pull request as ready for review March 20, 2024 03:01
@mattlord mattlord force-pushed the get_workflows_fix branch from c92d94b to 2920833 Compare March 20, 2024 03:04
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the get_workflows_fix branch from 2920833 to 2f3eaea Compare March 20, 2024 03:11
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit c830723 into vitessio:main Mar 21, 2024
102 checks passed
@mattlord mattlord deleted the get_workflows_fix branch March 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Bug Report: GetWorkflows RPC does not return any workflows
4 participants