-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VReplication: Fix workflow filtering in GetWorkflows RPC #15524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <mattalord@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Mar 19, 2024
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Mar 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15524 +/- ##
==========================================
+ Coverage 65.71% 65.72% +0.01%
==========================================
Files 1560 1560
Lines 194484 194485 +1
==========================================
+ Hits 127798 127824 +26
+ Misses 66686 66661 -25 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
changed the title
VReplication: Fix workflow filtering in GetWorkflows
VReplication: Fix workflow filtering in GetWorkflows RPC
Mar 20, 2024
mattlord
requested review from
ajm188,
deepthi and
rohit-nayak-ps
as code owners
March 20, 2024 03:01
mattlord
force-pushed
the
get_workflows_fix
branch
from
March 20, 2024 03:04
c92d94b
to
2920833
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
get_workflows_fix
branch
from
March 20, 2024 03:11
2920833
to
2f3eaea
Compare
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps
approved these changes
Mar 20, 2024
dbussink
approved these changes
Mar 21, 2024
GuptaManan100
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to the work done in #14424 where we moved reads against the vreplication table away from client side generated SQL to typed client-server RPCs (the server then builds the appropriate SELECT against the underlying table).
As part of that work, I errantly always included a workflow include filter in the new RPC request. The result of that is when you want to get/list all workflows, rather than just one, you get no results as the include workflow name filter is
''
— meaning only include workflows where the name is empty.This PR corrects that and adds tests for
vtctldclient
based "workflow list" related commands.Related Issue(s)
Checklist