Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest CodeQL #15530

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Update to latest CodeQL #15530

merged 1 commit into from
Mar 20, 2024

Conversation

dbussink
Copy link
Contributor

The v2 actions are deprecated, so this updates them. Marked for backporting do we don't get hit with the deprecation / breaking of this on older releases either.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Update to latest CodeQL
0e0344e 
The v2 actions are deprecated, so this updates them.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink added Backport to: release-17.0 Backport to: release-19.0 Needs to be back ported to release-19.0 labels Mar 20, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 20, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 20, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Mar 20, 2024
@dbussink dbussink added Component: Build/CI dependencies Pull requests that update a dependency file Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 20, 2024
@dbussink dbussink merged commit 55b05ec into vitessio:main Mar 20, 2024
112 of 116 checks passed
@dbussink dbussink deleted the dbussink/update-deprecated-codeql-actions branch March 20, 2024 14:22
@vitess-bot vitess-bot bot mentioned this pull request Mar 20, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Mar 20, 2024
@vitess-bot
Update to latest CodeQL (#15530)
37eda88 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
vitess-bot pushed a commit that referenced this pull request Mar 20, 2024
@vitess-bot
Update to latest CodeQL (#15530)
8b494fb 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot vitess-bot bot mentioned this pull request Mar 20, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Mar 20, 2024
@vitess-bot
Update to latest CodeQL (#15530)
3a9b81b 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot vitess-bot bot mentioned this pull request Mar 20, 2024
Merged
dbussink pushed a commit that referenced this pull request Mar 21, 2024
@vitess-bot
[release-19.0] Update to latest CodeQL (#15530) (#15534)
e55b9c1 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink pushed a commit that referenced this pull request Mar 21, 2024
@vitess-bot
[release-18.0] Update to latest CodeQL (#15530) (#15533)
1ef05bd 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
dbussink pushed a commit that referenced this pull request Mar 21, 2024
@vitess-bot
[release-17.0] Update to latest CodeQL (#15530) (#15532)
1c0d866 
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Build/CI dependencies Pull requests that update a dependency file Type: CI/Build
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dbussink @mattlord @rohit-nayak-ps