-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Ensure to pass down the precision #15611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were failing to pass down the precision correctly in the compiler which would lead to a panic because we'd see an unexpected type downstream. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
dbussink
added
Type: Bug
Component: Evalengine
changes to the evaluation engine
Backport to: release-19.0
Needs to be back ported to release-19.0
labels
Apr 2, 2024
dbussink
requested review from
harshit-gangal,
systay,
frouioui and
GuptaManan100
as code owners
April 2, 2024 08:41
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Apr 2, 2024
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Apr 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15611 +/- ##
==========================================
- Coverage 68.09% 68.07% -0.02%
==========================================
Files 1561 1561
Lines 195288 195288
==========================================
- Hits 132974 132947 -27
- Misses 62314 62341 +27 ☔ View full report in Codecov by Sentry. |
vmg
approved these changes
Apr 2, 2024
systay
approved these changes
Apr 2, 2024
GuptaManan100
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport to: release-19.0
Needs to be back ported to release-19.0
Component: Evalengine
changes to the evaluation engine
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were failing to pass down the precision correctly in the compiler which would lead to a panic because we'd see an unexpected type downstream.
Marked for backporting as this triggers an internal panic inside
vtgate
.Related Issue(s)
Fixes #15610
Checklist