-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-18.0] Update go.mod go version to 1.21.9 #15646
[release-18.0] Update go.mod go version to 1.21.9 #15646
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
@@ -1,6 +1,6 @@ | |||
module vitess.io/vitess | |||
|
|||
go 1.21 | |||
go 1.21.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future references, I don't think we really need to upgrade the minor version of go.mod with go1.21
. @shlomi-noach were you seeing errors without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not seeing errors without it, but the inconsistency led me to believe there was an oversight. For consistency alone I think it's worth keeping the version fully in sync.
Description
Followup to #15639, we were missing the updated go version in
go.mod
.Related Issue(s)
#15639
Checklist
Deployment Notes