[release-17.0] Upgrade go from 1.20.13 to 1.20.14

[GrahamCampbell]

Description

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[systay]

Thanks for this @GrahamCampbell!

You need to sign the commit for this to go through. That's what the DCO CI step is complaining about.

git commit --amend --no-edit -s

and the git push -f

[shlomi-noach]

@GrahamCampbell thank you -- can you please clarify the specific purpose of this version upgrade? As mentioned in #15650 (comment) the golang security fix was not made in 1.20. So I'm just checking, other than the good practice of staying up-to-date, is there a particular thing to look out for in this upgrade?

[GrahamCampbell]

There was a security fix, but not the same fix from this month. It was a fix from the round of golang releases before that.

[dbussink]

There was a security fix, but not the same fix from this month. It was a fix from the round of golang releases before that.

Right, we still need to look into if we need to upgrade to Go 1.21 here for example to address the latest issues.

[dbussink]

This also doesn't update the base images which is a separate process, so it's not going to be complete.

[frouioui]

Hello @GrahamCampbell, thank you for taking the time to think about doing this and creating the PR. We are still unsure whether or not to merge this or to directly upgrade to go1.21, we are going to talk about it.

In the meantime, upgrading the Golang version is little bit more involved than that. Refer to #15639 to see an example of how it is done. We need to bump the golang version used by vitess/bootstrap (as you did), and increment the minor version of the vitess/bootstrap by one, and then build and push the docker image.

Won't approve this for now as we are still reviewing with the rest of the maintainers.

[GrahamCampbell]

and increment the minor version of the vitess/bootstrap by one, and then build and push the docker image.

Right. That's not something I can do. ;)

[frouioui]

Right. That's not something I can do. ;)

You could change the bootstrap_version though.

[GrahamCampbell]

I can if you would like, but I though I'd leave that to whoever is going to do the rebuilding, if it's decided that this PR will be accepted at all.

[frouioui]

I am closing this Pull Request in favor of #15669, which upgrades to the next minor major version of Go.

Thank you @GrahamCampbell 🙇🏻