Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mysqlbinlog and xtrabackup to the vitess/lite image #15775

Merged
merged 19 commits into from
Apr 24, 2024

Conversation

frouioui
Copy link
Member

@frouioui frouioui commented Apr 22, 2024

Description

This Pull Request modifies the vitess/lite image by basing it on the mysql80 bootstrap image instead of common and copying the mysqlbinlog image from the base image. It also now installs xtrabackup on it.

~/vitess# docker build -f docker/lite/Dockerfile -t vitess/lite:test . 
...
~/vitess# docker run -it vitess/lite:test bash 
vitess@8b74fb4dd126:/$ xtrabackup -v
xtrabackup version 8.0.35-30 based on MySQL server 8.0.35 Linux (x86_64) (revision id: 6beb4b49)
vitess@8b74fb4dd126:/$ mysqlbinlog -V
mysqlbinlog  Ver 8.0.36 for Linux on x86_64 (MySQL Community Server - GPL)
vitess@8b74fb4dd126:/$

The image size is slightly increased from 1.22GB to 1.49GB:

~/vitess# docker image ls
REPOSITORY         TAG          IMAGE ID       CREATED         SIZE
vitess/lite        test          10e43cf2cf7b      2 minutes ago   1.49GB
vitess/lite        latest       64435ce82eb0   7 hours ago       1.22GB

Cleanups

I am also removing the lite ubi7 and ubi8 images in this PR as they don't seem to be used and @aquarapid (who added them initially) suggested.

We never built or pushed the .testing variant and can be replaced by vttestserver which we already build and push for every commit to main and tag. This Dockerfile is now removed.

With only one Dockerfile left in lite, the Makefile is also simplified.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Copy link
Contributor

vitess-bot bot commented Apr 22, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 22, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 22, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui added Type: Bug Component: Docker and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 22, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review April 22, 2024 23:41
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as draft April 23, 2024 16:07
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.44%. Comparing base (a89b2cb) to head (d896a3b).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15775      +/-   ##
==========================================
+ Coverage   68.43%   68.44%   +0.01%     
==========================================
  Files        1556     1558       +2     
  Lines      195433   195822     +389     
==========================================
+ Hits       133743   134035     +292     
- Misses      61690    61787      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review April 23, 2024 19:42
@frouioui frouioui requested a review from dbussink April 23, 2024 19:46
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
Copy link
Member Author

Actually I will try to add xtrabackup into the lite image as part of this PR. Re-marking this as draft.

@frouioui frouioui marked this pull request as draft April 23, 2024 19:54
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui changed the title Re-add mysqlbinlog to the vitess/lite image Add mysqlbinlog and xtrabackup to the vitess/lite image Apr 23, 2024
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui marked this pull request as ready for review April 23, 2024 21:47
docker/lite/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@deepthi deepthi merged commit 96b1419 into vitessio:main Apr 24, 2024
104 checks passed
@deepthi deepthi deleted the add-mysqlbinlog-to-lite branch April 24, 2024 18:51
@shlomi-noach
Copy link
Contributor

Nice! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The need to include a mysqlbinlog binary in a k8s deployment
4 participants