-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the golang version used vitess-mixin
#15972
Merged
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:fix-vitess-mixin-go-version
May 20, 2024
Merged
Upgrade the golang version used vitess-mixin
#15972
harshit-gangal
merged 2 commits into
vitessio:main
from
planetscale:fix-vitess-mixin-go-version
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
requested review from
systay,
ajm188,
deepthi,
harshit-gangal,
mattlord and
rohit-nayak-ps
as code owners
May 17, 2024 19:40
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
May 17, 2024
frouioui
added
Type: Internal Cleanup
Component: Observability
Pull requests that touch tracing/metrics/monitoring
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
May 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15972 +/- ##
==========================================
- Coverage 68.45% 68.44% -0.01%
==========================================
Files 1562 1562
Lines 197057 197059 +2
==========================================
- Hits 134891 134881 -10
- Misses 62166 62178 +12 ☔ View full report in Codecov by Sentry. |
5 tasks
systay
approved these changes
May 20, 2024
harshit-gangal
approved these changes
May 20, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until we find out what we want to do with vitess-mixin this PR upgrades the golang version to what we use in the rest of the codebase and update the golang upgrade tool to also upgrade the go.mod of vitess-mixin in the future.