Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] feat: add a LIMIT 1 on EXISTS subqueries to limit network overhead (#16153) #16193

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 14, 2024

Description

This is a backport of #16153

…16153)

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner June 14, 2024 17:37
@vitess-bot vitess-bot bot requested a review from systay as a code owner June 14, 2024 17:37
@vitess-bot vitess-bot bot added Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Regression labels Jun 14, 2024
Copy link
Contributor Author

vitess-bot bot commented Jun 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Sorry, something went wrong.

@github-actions github-actions bot added this to the v20.0.0 milestone Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 25 lines in your changes missing coverage. Please review.

Project coverage is 68.54%. Comparing base (d2d60be) to head (c0af817).

Files Patch % Lines
.../vt/vtgate/planbuilder/operators/query_planning.go 67.53% 25 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16193      +/-   ##
================================================
- Coverage         68.55%   68.54%   -0.01%     
================================================
  Files              1541     1541              
  Lines            197628   197712      +84     
================================================
+ Hits             135476   135527      +51     
- Misses            62152    62185      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit 4baa524 into release-20.0 Jun 15, 2024
186 checks passed
@frouioui frouioui deleted the backport-16153-to-release-20.0 branch June 15, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant